-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Import groups linting #240
Conversation
golangci-lint will now group imports in the following order: - standard library - 3rd party packages outside of our Github org - packages from our Github org - local imports from catalogd Signed-off-by: Tayler Geiger <tayler@redhat.com>
Signed-off-by: Tayler Geiger <tayler@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #240 +/- ##
=======================================
Coverage 48.84% 48.84%
=======================================
Files 8 8
Lines 434 434
=======================================
Hits 212 212
Misses 201 201
Partials 21 21 ☔ View full report in Codecov by Sentry. |
- standard | ||
- default | ||
- prefix(github.com/operator-framework) | ||
- prefix(github.com/operator-framework/catalogd) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use localmodule
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like localmodule is only working in gci 0.13.4 which isn't included in a release of golangci-lint yet.
"github.com/spf13/pflag" | ||
"k8s.io/apimachinery/pkg/runtime" | ||
utilruntime "k8s.io/apimachinery/pkg/util/runtime" | ||
clientgoscheme "k8s.io/client-go/kubernetes/scheme" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we have conflicting linters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's due to the following comments on 32-33. Removing those fixes the incompatibility.
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Looks like this will need a rebase if we want to still get this in |
Looks like @joelanford already knocked this out here: #255 |
Pull request was closed
Adds linter grouping to match configuration in operator-controller.